Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airshipctl document validate #2

Closed
jezogwza opened this issue Jan 29, 2020 · 3 comments
Closed

airshipctl document validate #2

jezogwza opened this issue Jan 29, 2020 · 3 comments
Labels
1-Core Relates to airshipctl core components (i.e. go code) epic Features or large improvements reflected as a list of issues priority/medium Default priority for items sig/yaml Relates to the YAML special interest group.
Projects
Airship 2.0
Milestone
v2.1

Comments

@jezogwza
Copy link
Contributor

document validation explicitly will implement
validation rules beyond the simple yaml rendering validation done via kustomize mechanism.
This command will provide a way for enforcing validation policies such as :

  • Expectations on CR cross reference
  • Expectations on valid information (does certain CR define the min set of required things)
  • Expectations on valid data on the CR
@jezogwza jezogwza added the enhancement New feature or request label Jan 29, 2020
@jezogwza jezogwza added this to the betav1 milestone Jan 29, 2020
@jezogwza jezogwza added this to To do in Airship 2.0 via automation Jan 29, 2020
@drewwalters96 drewwalters96 added the sig/yaml Relates to the YAML special interest group. label Feb 10, 2020
@ianpittwood
Copy link
Contributor

I think we should designate this as an epic since there will be several commands to implement under document validate. Thoughts?

@ianpittwood ianpittwood added epic Features or large improvements reflected as a list of issues and removed enhancement New feature or request labels Feb 10, 2020
@drewwalters96
Copy link
Contributor

I think that makes sense @ianpittwood; this includes several parts, per the design discussions.

@ianpittwood ianpittwood mentioned this issue Feb 10, 2020
Closed
@jezogwza jezogwza added the triage Needs evaluation by project members label Mar 4, 2020
@jezogwza jezogwza added priority/medium Default priority for items and removed triage Needs evaluation by project members labels Mar 11, 2020
@jezogwza jezogwza modified the milestones: betav1, v2.0 Aug 19, 2020
@airshipbot airshipbot mentioned this issue Sep 30, 2020
Closed
@mattmceuen mattmceuen mentioned this issue Oct 13, 2020
Closed
@eak13 eak13 added 1-Core Relates to airshipctl core components (i.e. go code) and removed component/document labels Dec 8, 2020
@lb4368 lb4368 modified the milestones: v2.0, Future Mar 10, 2021
@airshipbot
Copy link

airshipbot commented Apr 5, 2021 •
edited
Loading

Related Change #780681

Subject: Add validation phases
Link: https://review.opendev.org/c/airship/airshipctl/+/780681
Status: MERGED
Owner: Ruslan Aliev (raliev@mirantis.com)

This change will close this issue when merged.

Approvals

Code-Review
+2 Matt McEuen
+2 Kostyantyn Kalynovskyi
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2021-04-27 22:39:02 CDT

Airship 2.0 automation moved this from To do to Done Apr 28, 2021
@jgu17 jgu17 mentioned this issue Apr 30, 2021
Closed
@lb4368 lb4368 modified the milestones: Future, v2.1 Jun 4, 2021
@mattmceuen mattmceuen mentioned this issue Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1-Core Relates to airshipctl core components (i.e. go code) epic Features or large improvements reflected as a list of issues priority/medium Default priority for items sig/yaml Relates to the YAML special interest group.
Projects
Airship 2.0
  
Done
Milestone
v2.1
Development

No branches or pull requests
6 participants
@lb4368 @eak13 @jezogwza @drewwalters96 @ianpittwood @airshipbot