Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Header Parameter Names #277

Open
tobihagemann opened this issue Aug 11, 2022 · 3 comments
Open

Custom Header Parameter Names #277

tobihagemann opened this issue Aug 11, 2022 · 3 comments

Comments

@tobihagemann
Copy link
Contributor

Currently, the header parameters are strictly defined and I couldn't find a way to extend them with custom ones.

In JOSEHeader and its implementations, parameters can only be accessed internally so that you can't define custom parameters outside of this library.

Would it make sense to make parameters public? Or any other idea how custom header parameter names can be accomplished?

@CyberMew
Copy link

+1 to this. At least let us extend the “fixed header”parameters ourselves via an extension or expose it or something. Is the current behaviour strictly by design?

@olev-abel
Copy link

+1 for that. Since RFC7516 clearly states the Private Header Names, library should support both writing and reading them, as one of the purposes of the Private Headers are to validate their content before proceeding with the decryption.

taavi224 added a commit to LabMobi/CryptoLibJOSESwift that referenced this issue Dec 7, 2022
taavi224 added a commit to LabMobi/CryptoLibJOSESwift that referenced this issue Dec 7, 2022
@tobihagemann
Copy link
Contributor Author

Ah, very nice, there is already a PR #282 by @taavi224 for this. To be honest, there are already multiple PRs that would just need a merge so that this library gets better and better but I'm not sure what the maintainers are up to. I know that I can maintain my own fork but it would be great if these changes could be merged upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants