Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove java jukebox #636

Merged

Conversation

randomnicode
Copy link
Collaborator

@randomnicode randomnicode commented Sep 27, 2021

The Java Jukebox relies on an external library written by @biconou which hasn't been updated for newer JVMs. A bunch of the code in the library uses internal sun classes that, following modularization of Java either isn't available or isn't exposed to public anymore, which makes porting to newer JVMs slightly more difficult.

There were other issues with the tech, leading to a whole host of issues. It was never fully tested and therefore not fully integrated, and ultimately dev work on it was abandoned.

Because the original author is not responsive, and we need to keep updating airsonic for recent JVMs, we need to regretfully remove this piece of tech. Anyone who relies on java_jukebox, should stay on a previous version.

Consequences:

  • All java_jukebox players will be converted to plain jukebox players
  • All references to java jukeboxes will be dropped and scrubbed from the database. There is NO GOING BACK! You won't be able to install an older version of airsonic and regain java_jukebox functionality.

Fixes #625, #628, #615

@randomnicode randomnicode added the breaking change Breaking change label Sep 27, 2021
@randomnicode randomnicode merged commit 18d97b9 into airsonic-advanced:master Oct 1, 2021
@randomnicode randomnicode deleted the removejavajukebox branch October 1, 2021 06:57
@gerroon
Copy link

gerroon commented Nov 11, 2021

Does that mean that no more remote Jukebox playback functionality (play on the server) using Dsub or similar apps? Becasue I cant get the Docker container to play to the host's Pulse server.

@randomnicode
Copy link
Collaborator Author

No, the original (legacy) jukebox is still there, which is what Subsonic uses.
Only the newer partially integrated implementation attempt by Airsonic writers (java jukebox) was removed.

@BigMula11
Copy link

Does that mean that no more remote Jukebox playback functionality (play on the server) using Dsub or similar apps? Becasue I cant get the Docker container to play to the host's Pulse server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change
Projects
None yet
3 participants