Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide environment variables #624

Closed
pitrou opened this issue Feb 20, 2018 · 1 comment
Closed

Provide environment variables #624

pitrou opened this issue Feb 20, 2018 · 1 comment
Labels
enhancement Triaged as an enhancement request

Comments

@pitrou
Copy link
Contributor

pitrou commented Feb 20, 2018

It would be useful for asv to set up environment variables when running either the install steps (setup.py build or pip install) or the benchmarks themselves.

I'm thinking something like:

  • ASV=true
  • ASV_PROJECT=<project name>
  • ASV_COMMIT=<git commit id>
  • ASV_ENV_NAME=conda-py3.6-etc
  • ASV_ENV_PATH=<path to .asv/env/envhash>
  • ASV_ENV_TYPE=conda
@pitrou
Copy link
Contributor Author

pitrou commented Feb 20, 2018

This may also allow implementing support for #78 more easily.

pitrou added a commit to pitrou/asv that referenced this issue Feb 20, 2018
… to subprocesses

This follows a general pattern in development and integration tools.
@pv pv added the enhancement Triaged as an enhancement request label Apr 12, 2018
@pv pv closed this as completed in 2132195 Jul 7, 2018
pv added a commit that referenced this issue Jul 7, 2018
Provide ASV-specific environment variables to subprocesses

Fixes #624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Triaged as an enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants