Changes required to set minimum Python version to 3.7 #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the changes @LucyJimenez
I think updating the versions in the asv.conf.json page makes sense. IMO it looks better not using versions so much in the past, and maybe a bit misleading to show unsupported versions. But up to you.
docs/source/installing.rst
Outdated
| @@ -2,7 +2,7 @@ Installing airspeed velocity | |||
| ============================ | |||
|
|
|||
| **airspeed velocity** is known to work on Linux, Mac OS-X, and Windows. | |||
| It is known to work with Python 2.7, 3.4, 3.5, and 3.6. | |||
| It is known to work with Python 3.7. | |||
There was a problem hiding this comment.
do you mind saying with Python 3.7 and higher. please?
docs/source/using.rst
Outdated
| in the ``asv.conf.json`` file available on the ``PATH``. For example, | ||
| if the ``asv.conf.json`` file has:: | ||
|
|
||
| "pythons": ["2.7", "3.6"] | ||
| "pythons": ["3.7"] |
There was a problem hiding this comment.
I think the example is clearer if you use 2 versions, maybe 3.7 and 3.10.
Perfect, I'll do it! |
datapythonista
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #1022
Update the required Python version on
setup.pyand some parts of the documentation.@datapythonista do you think we need to update the examples on the exclude and include part? https://asv.readthedocs.io/en/stable/asv.conf.json.html