Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Allow newlines in benchmark names #1256

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Mar 20, 2023

Closes #964.

Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
@mattip mattip merged commit 66e9c89 into airspeed-velocity:master Apr 23, 2023
@mattip
Copy link
Contributor

mattip commented Apr 23, 2023

Thanks @HaoZeke. Maybe you could add a test in a future PR to make sure we do not break this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regressions.js fails if a benchmark parameter contains newline (\n)
2 participants