-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for named benchmarks #484
Conversation
b7d7554
to
baff01d
Compare
baff01d
to
f1fe09b
Compare
f1fe09b
to
81c06eb
Compare
I guess this is mostly OK. Comments:
|
* move benchmark discovery and instanciation related code in disc_benchmark() * rename from_name() to get_benchmark_from_name() outside of Benchmark class * use disc_benchmark() in get_benchmark_from_name(), less optimized version but more readable and no more rely on benchmark name. Related to airspeed-velocity#481
011b53f
to
56c3e2c
Compare
This allow to control the full name of a benchmark function Related to airspeed-velocity#481
56c3e2c
to
3f14e67
Compare
Sorry for the delay. Pushed new commits with The current implementation of benchmark discovery by name use a generator, so it doesn't always import the whole suite. Nevertheless I re-implemented direct import of benchmark in 9fb848e Thanks ! |
The benchmark suite import time can be similar to the benchmark runtime.
For example, for the scipy benchmark suite, it's 0.5 sec vs. ~0.1 sec
per-file. For pandas, it's ~ 1.0 sec total vs. 0.3 sec per-file (both
with hot disk cache here).
|
Note that the 'benchmarks' package name should be replaced by dirname(root).
|
9fb848e
to
fe0e2d3
Compare
Good catch ! I updated the commit. |
Related to #481