Perform benchmark discovery only when running benchmarks #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
force-pushed
the
discover-failsafe
branch
5 times, most recently
from
513ebce
to
f0d4b7c
Compare
Discover benchmarks only when the project is going to be built and the commit hashes to be checked are known, so the benchmark discovery can be performed using those commits. This also adjusts the Benchmarks API so that the discovery is explicit. Previously, benchmark discovery was done installing a version of the project at the tip of the branch or from an existing wheel. This leads to problems when the build fails or the project is not in an importable state. This also changes "asv publish" to emit an error message rather than running benchmark discovery, if benchmarks.json is damaged or missing. That is an unusual error condition, so it is reasonable to handle it as such (the error message explains how to resolve it).
|
I think this has been dogfooded for long enough now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discover benchmarks only when the project is going to be built and the
commit hashes to be checked are known, so the benchmark discovery can be
performed using those commits. This also adjusts the Benchmarks API so
that the discovery is explicit.
Previously, benchmark discovery was done installing a version of the
project at the tip of the branch or from an existing wheel. This leads
to problems when the build fails or the project is not in an importable
state.
This also changes "asv publish" to emit an error message rather than
running benchmark discovery, if benchmarks.json is damaged or missing.
That is an unusual error condition, so it is reasonable to handle it as
such (the error message explains how to resolve it).