-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up test suite #637
Merged
Merged
Speed up test suite #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
force-pushed
the
ci-parallel
branch
6 times, most recently
from
April 30, 2018 22:15
a2219b5
to
965c754
Compare
pv
force-pushed
the
ci-parallel
branch
19 times, most recently
from
May 1, 2018 20:31
1f946ed
to
a9e53d1
Compare
This is more robust vs. PYTHONPATH containing '' (current directory), which occurs when running under pytest-xdist. Running in a temporary directory is also consistent with how benchmarks themselves are run.
This speeds up the benchmarks by 50+ sec
Disable pytest-timeout, as it appears incompatible with xdist
…in thread Setting signal handlers works only in the main thread. Typically, asv is single-threaded, but when running tests, pytest-xdist doesn't seem to always guarantee the tests are run in the main thread.
This may avoid sending signals to workers, which can bump into multiprocessing bugs on python 2
Use only the currently installed Python version, plus a second version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests in parallel with pytest-xdist.
Fix timing issues that caused problems with pytest-xdist.
Use
--bench=
in tests to avoid running the whole slow benchmark suite.Prefer close+join when using multiprocessing, to avoid some issues on python2 on windows.
Fix test_web:basic_html fixture to work with pytest-xdist.
Add --offline option for running tests without pip/conda downloading.
Pre-download necessary packages before running tests, which also mitigates some issues with conda's parallel execution safety.