Benchmark runner refactoring and interleaved benchmark sampling #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this related to the issue discussed in #595? |
|
@jbrockmendel: yes, although it does not interleave between different commits. |
pv
changed the title
Fix some exceptions raised in the test benchmark suite, and fix the code checking for functionality of number/repeat
Instead of doing benchmark planning/running/printing result in one go, decouple these steps from each other. Before running, construct a list of Job objects to run. Then run them one by one, printing the results. Splitting benchmark sample collection to multiple processes for interleaved runs is done in the planning step. The interleaved benchmark runs (i.e. sampling split to multiple parts, run in an interleaved order) ensure that all benchmarks can sample over long-time variations in CPU and other background environmental factors.
…when running Add --attribute/-a option for providing override values for benchmark attributes in Run/Dev/Continuous. Useful e.g. with timing benchmarks. Only attributes with base-type values can be overridden, since they are passed as json-serialized.
Minimum at 5 samples per process enables people to scale up more easily just by increasing `processes` without having to set `repeat` at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor benchmark runner by decoupling preparation/running/result printing steps from each other.
Also enable interleaved sampling runs, i.e. each benchmark run is split to multiple parts and these are run in an interleaved order. This enables each benchmark to sample over long-time variations in CPU and other background factors.