Avoid making long result file names by replacing env name by hash if long #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
force-pushed
the
result-long-filename
branch
2 times, most recently
from
f22dd1b
to
947782d
Compare
…long The result file name lengths should be limited to some reasonable size, as there can in principle be arbitrary many dependencies. Replace the environment name by its hash if it's longer than 128 characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result file name lengths should be limited to some reasonable size,
as there can in principle be arbitrary many dependencies. Replace the
environment name by its hash if it's longer than 128 characters.
The rest of asv code does not assume result files are named in a particular
way, just that the mapping is deterministic and unique (which even MD5 hashes
satisfy for non-attack inputs).
Fixes gh-621