Adjust timing benchmarking #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ample_time' Change default for sample_time to 10ms. This is sufficiently long for obtaining accurate measurements with most timers, with reasonable accuracy retained. Since asv runs a large number of benchmarks, it is important that the measurement times are kept short. Make 'repeat' determination to work on the basis of a given range (min_repeat, max_repeat) and a maximum allocated time max_time. Change min_timeit_count to min_run_count. This is retained separately from min_repeat, as its purpose is different (e.g. deal with numba jit compilation) and it is counted also during warmup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default for sample_time to 10ms. This is sufficiently long for
obtaining accurate measurements with most timers, with reasonable
accuracy retained (in practice). Since asv runs a large number
of benchmarks, it is important that the measurement times are kept short.
Make 'repeat' determination to work on the basis of a given range
(min_repeat, max_repeat) and a maximum allocated time max_time.
Change min_timeit_count to min_run_count. This is retained separately
from min_repeat, as its purpose is different (e.g. deal with numba jit
compilation) and it is counted also during warmup, unlike min_repeat.
Closes gh-653
TODO: