Change suggested badge colour #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest to change the suggested badge-color from green to blue. Red-green is often used to show if tests or builds were successful or not (readthedocs, travis, etc), and red-orange-green is often used to show the status (coveralls, codacy). However, the asv-badge is a static link, indicating that it is benchmarked with asv. So I suggest to show it in blue, as for instance used by Zenodo for its doi, or py pypi and conda for the version number; static info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to change the suggested badge-color from green to blue. Red-green is often used to show if tests or builds were successful or not (readthedocs, travis, etc), and red-orange-green is often used to show the status (coveralls, codacy). However, the asv-badge is a static link, indicating that it is benchmarked with asv. So I suggest to show it in blue, as for instance used by Zenodo for its doi, or py pypi and conda for the version number; static info.
From
to 
.
Of course, any user can adjust the badge to his likes anyway, but I thought it would be better to have blue in the suggested markdown.