Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery and flot #772

Merged
merged 5 commits into from
Nov 27, 2018
Merged

Update jQuery and flot #772

merged 5 commits into from
Nov 27, 2018

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Nov 12, 2018

Running with jQuery-migrate, there are only warnings about bind/unbind and event shortcuts. I have fixed them in the code here, though there are still some bits that trigger the deprecation in flot (which btw, seems a bit dead?). Based on my reading of the issues, these deprecations are very long term, so the flot ones may not even be anything to worry about.

I tried clicking on everything I could and did not see any regressions. From what I understood of the changelog, the version bump was mostly internal (at least as far as what asv does with it.)

This depends on airspeed-velocity/asv-vendor#1

@pv pv merged commit 75703fb into airspeed-velocity:master Nov 27, 2018
@pv
Copy link
Collaborator

pv commented Nov 27, 2018

Thanks, indeed seems to work.

That flot development is stopped is maybe fine, it looks fairly feature complete as far as asv is concerned... If it stops completely working one day, it should be straightforward to switch to a different plotting framework.

@QuLogic QuLogic deleted the update-js branch November 28, 2018 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants