Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualenv no longer supports --no-site-packages; remove it. #917

Merged

Conversation

DWesl
Copy link
Contributor

@DWesl DWesl commented May 11, 2020

I got crashes when trying to use asv with latest virtualenv.

I think virtualenv >= 20.0.0b1 removed --no-site-packages, with no readily apparent replacement.
However, virtualenv >= 1.7 apparently has this as the default, so that may be less needed now than it once was.

It may be worth adding a setuptools virtualenv extra to make sure the virtualenv version is recent enough.

Closes #906
Alternate: #905

@DWesl
Copy link
Contributor Author

DWesl commented May 11, 2020

The pyflakes errors look unrelated. I suspect the appveyor errors are as well, but I don't know the configuration well enough to tell.

I doubt the PyPy failures are related, but I did what I could to fix them. It doesn't seem to have worked, and I don't have access to a machine with PyPy.

DWesl added 3 commits May 11, 2020 19:12
For some reason I had ">-", which is not a thing.
It should also be possible to `$TRAVIS_PIP install -r requirements-dev.txt`
@pv pv merged commit 3ef7c50 into airspeed-velocity:master May 14, 2020
@pv
Copy link
Collaborator

pv commented May 14, 2020

Thanks, merged.

@DWesl DWesl deleted the virtualenv-removed-no-site-packages branch May 14, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure when creating virtualenv
2 participants