Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ${Name} as variable for save path (CLI only) #623

Merged

Conversation

clydegale
Copy link
Contributor

I'm using blobsaver with a lot of different devices (awesome project BTW :). The saved blobs can currently only be uniquely identified by the ECID, Generator or APNonce, none of which are easy to remember when working with multiple different devices. IMO it would be easier to save the blobs into a subdirectory with a name one can specify, i.e. the "saved device" name.

With the current changes this only works in CLI mode for imported/saved devices when requesting in background (my use-case).

However if you want I can add further changes to make it possible in the GUI as well:
I propose a new "Name" field in the GUI, possibly above the ECID field. This would make the "Name Device" popup obsolete (at least when a name is already given). Then when building the TSS object the Name would be accessible in Controller.java:656 (createTSS).

@clydegale
Copy link
Contributor Author

While I'm at it: In https://github.com/airsquared/blobsaver/wiki/Building you define JDK 19 however build.gradle and the github actions seem to already use JDK 20. Just fyi :)

@airsquared
Copy link
Owner

airsquared commented Sep 29, 2023

This looks good, thanks for the contribution!

I don't know about making a new name field available (already too many configuration options in the UI), but maybe when a saved device is selected in the GUI, the saved device's could be used.

While I'm at it: In https://github.com/airsquared/blobsaver/wiki/Building you define JDK 19 however build.gradle and the github actions seem to already use JDK 20. Just fyi :)

Fixed :)

@airsquared airsquared force-pushed the add-feature/device-name-as-save-path branch from 85b3367 to e2cb2f8 Compare September 29, 2023 07:50
@clydegale
Copy link
Contributor Author

Alright, I had a look and somehow thought it would be more complex. I needed to add a deviceName variable in Controller since selecting a device is handled in a callback and after focus loss the device is deselected from the deviceList (i.e. it is currently not persisted upon selection).

I also added a warning if the user uses ${Name} without first selecting a saved device.

Any thoughts?

@airsquared airsquared force-pushed the add-feature/device-name-as-save-path branch from d0379ad to 884e21f Compare October 6, 2023 20:46
@airsquared
Copy link
Owner

Looks good, merging

@airsquared airsquared merged commit 2e591e5 into airsquared:master Oct 6, 2023
5 checks passed
@clydegale clydegale deleted the add-feature/device-name-as-save-path branch October 10, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants