Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (#1252): respect Redis StreamSub last_id with consumer group #1256

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

Lancetnik
Copy link
Collaborator

Description

Fixes #1254

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the enhancement New feature or request label Feb 23, 2024
@kumaranvpl kumaranvpl self-assigned this Feb 23, 2024
@kumaranvpl kumaranvpl added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit e5ec0cb Feb 23, 2024
31 checks passed
@kumaranvpl kumaranvpl deleted the feat-1254 branch February 23, 2024 11:52
@chrisgoddard
Copy link

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Feature: support last_id for Redis stream consumer group
3 participants