-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config param to pass additional parameters to confluent-kafka-python #1505
Conversation
@Lancetnik Points to discuss
|
@kumaranvpl your decision looks good to me, but I have some notices:
|
@@ -14,6 +15,9 @@ | |||
|
|||
|
|||
def parse_security(security: Optional[BaseSecurity]) -> "AnyDict": | |||
if security and isinstance(security.ssl_context, ssl.SSLContext): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we should use SetupError
instead of basic ValueError
in wrong broker parameters case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, I think, we can release it
Description
config
param which needs to be passed toconfluent-kafka-python
ssl_context
SetupError
ifssl_context
is passedTypedDict
forconfig
Fixes #1405
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh