Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish contributing file and remove duplicate docker compose file #734

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Polish contributing file and remove duplicate docker compose file #734

merged 2 commits into from
Sep 25, 2023

Conversation

kumaranvpl
Copy link
Contributor

@kumaranvpl kumaranvpl commented Sep 25, 2023 •
edited

Description

  • Polish contributing file by running it through ChatGPT
  • Remove duplicate docker compose file to start test dependencies

Fixes #506

Type of change

  • Documentation (typos, code examples, or any documentation updates)

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh

@kumaranvpl kumaranvpl linked an issue Sep 25, 2023 that may be closed by this pull request
Polish contributing file #506
Closed
@davorrunje davorrunje added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit d1776c0 Sep 25, 2023
19 checks passed
@davorrunje davorrunje deleted the 506-polish-contributing-file branch September 25, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorrunje davorrunje davorrunje approved these changes

Assignees

@davorrunje davorrunje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polish contributing file
2 participants
@kumaranvpl @davorrunje