Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

585 complete kafka part of faststream docs #775

Merged
merged 18 commits into from
Sep 29, 2023

Conversation

sternakt
Copy link
Collaborator

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes #585

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

Copy link
Collaborator

@Lancetnik Lancetnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test_me.py to pytest run?

@sternakt
Copy link
Collaborator Author

Can you add test_me.py to pytest run?

Renamed the examples in docs_src from test_me.py to example.py and referenced in tests folder

@Lancetnik
Copy link
Collaborator

But why we are running the same test twice for now?

@sternakt
Copy link
Collaborator Author

But why we are running the same test twice for now?

My mistake, referenced the wrong one in one of the tests

One test is for the example where we use the general publish of the FastStream and another is when we first create a publisher object and then use its publish method

Fixed it :)

@davorrunje davorrunje added this pull request to the merge queue Sep 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2023
@davorrunje davorrunje added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit b5df079 Sep 29, 2023
19 checks passed
@davorrunje davorrunje deleted the 585-Complete-Kafka-part-of-faststream-docs branch September 29, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete Kafka part of faststream docs
3 participants