Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better RMQ AsyncAPI #879

Merged
merged 5 commits into from
Oct 20, 2023
Merged

feat: better RMQ AsyncAPI #879

merged 5 commits into from
Oct 20, 2023

Conversation

Lancetnik
Copy link
Collaborator

Description

Close #878 (remove is_installed call to just try import, except ImportError)
Close #875 (publisher hash depends on routing_key too, add extra AsyncAPI information for RMQ bindings)
Close #876 (declare publisher's exchange on application startup)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the enhancement New feature or request label Oct 20, 2023
@davorrunje davorrunje added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit 6873f1b Oct 20, 2023
23 checks passed
@davorrunje davorrunje deleted the rabbit-asyncapi branch October 20, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
2 participants