Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: limit open dev dependency versions #953

Merged
merged 2 commits into from
Nov 16, 2023
Merged

chore: limit open dev dependency versions #953

merged 2 commits into from
Nov 16, 2023

Conversation

kumaranvpl
Copy link
Contributor

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl linked an issue Nov 16, 2023 that may be closed by this pull request
Use pinned versions for dev dependecies #922
Closed
@kumaranvpl kumaranvpl marked this pull request as draft November 16, 2023 06:04
@kumaranvpl kumaranvpl marked this pull request as ready for review November 16, 2023 06:08
davorrunje
davorrunje reviewed Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@davorrunje davorrunje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just pin dev deps to exact version. We will upgrade them regularly.

pyproject.toml Outdated
"dirty-equals==0.6.0",
]

testing = [
"faststream[test-core]",
"fastapi>=0.100",
"pydantic-settings>2",
"fastapi>=0.100,<0.200",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

pyproject.toml
@@ -95,7 +95,7 @@ lint = [
"types-docutils",
"mypy==1.7.0",
"black==23.11.0",
"isort>=5",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we pin this to exact version?

@davorrunje davorrunje changed the title Limit open dev dependency versions chore: limit open dev dependency versions Nov 16, 2023
@davorrunje davorrunje added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 7763d47 Nov 16, 2023
23 checks passed
@davorrunje davorrunje deleted the 922-use-pinned-versions-for-dev-dependecies branch November 16, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorrunje davorrunje davorrunje approved these changes

Assignees

@davorrunje davorrunje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use pinned versions for dev dependecies
2 participants
@kumaranvpl @davorrunje