Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add left out md files to fix broken links #987

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Add left out md files to fix broken links #987

merged 3 commits into from
Nov 24, 2023

Conversation

kumaranvpl
Copy link
Contributor

Description

We were globally ignoring all the dirs called "site". But we have some api "faststream.asyncapi.site.get_asyncapi_html". Because of the gitignore all the markdown files for the above api which is under "docs/docs/en/api/faststream/asyncapi/site" directory were ignored. I have fixed it by explicitly ignoring docs/site directory.

Also reduced rate limit in order to prevent getting 429 from github.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@davorrunje davorrunje added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 487c86f Nov 24, 2023
23 checks passed
@davorrunje davorrunje deleted the fix-broken-lins branch November 24, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants