Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old IE in airtap client code. #274

Closed
wants to merge 1 commit into from

Conversation

goto-bus-stop
Copy link
Contributor

@goto-bus-stop goto-bus-stop commented Jan 17, 2020

The simplest alternative to #273.

This makes airtap's tape client code work in IE9 (and maybe earlier,
buffer@4 actually works all the way back to IE6 afaik).

This only applies to airtap's own code so if old IE support is required
for a project's browser tests, they still need to do the config thing:

browserify:
- require: 'buffer/'
  expose: 'buffer'

So projects can still use the new buffer implementation, airtap itself
will just be using the old one for maximum compatibility.

Closes #273

@vweevers
Copy link
Member

vweevers commented Jan 17, 2020

Is there any risk / gotchas to potentially having 2 semi-global versions of buffer in the client?

@goto-bus-stop
Copy link
Contributor Author

I don't think so. They don't affect the global object. The only risk would be if a Buffer was somehow sent from one bundle to the other, and the other bundle used some functionality that is not supported by that Buffer. But all common operations are available on both, and the Buffer.isBuffer() function is provided by is-buffer which works with both versions. AFAIK buffers are never passed around like that in airtap in the first place, so even if there was a difference it prob wouldn't matter 😄

@vweevers
Copy link
Member

@goto-bus-stop Alright if we let this sit for a few days, or are you blocked by it?

@goto-bus-stop
Copy link
Contributor Author

Alright even if it sits for a very long time, no hurry

@vweevers
Copy link
Member

I'm gonna explore #57 for a little bit, then we wouldn't need buffer at all and can also use the latest tap-parser in the backend.

@vweevers vweevers mentioned this pull request Jan 20, 2020
27 tasks
@vweevers vweevers deleted the ie9-unconditional branch August 23, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants