Update dependencies #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow-copy, stack-mapper and tap-finished
ralphtheninja
commented
Feb 19, 2018
frameworks/render-stacktrace.js
Outdated
| @@ -1,6 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| var hljs = require('./hl.js'); | |||
| // var hljs = require('./hl.js'); | |||
There was a problem hiding this comment.
The highlight.js api was improved and can now be required directly without the funky stuff in hl.js
ralphtheninja
commented
Feb 19, 2018
| }; | ||
| }(); | ||
| hljs.LANGUAGES['javascript'] = require('highlight.js/javascript.js')(hljs); | ||
| module.exports = hljs; |
There was a problem hiding this comment.
This code is now part (or rather, more modern version of it) of highlight.js
ralphtheninja
commented
Feb 19, 2018
lib/control-app.js
Outdated
|
|
||
| app.use(bundle_router.middleware); |
There was a problem hiding this comment.
.middleware is old api.
ralphtheninja
commented
Feb 19, 2018
package.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "dependencies": { | |||
| "JSON2": "~0.1.0", | |||
| "batch": "~0.6.1", | |||
| "browserify": "13.0.0", | |||
| "browserify": "~15.2.0", | |||
There was a problem hiding this comment.
We can't use 14.x and above if we want to keep support for IE9 and IE10.
Merged
|
0.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates everything but the dependencies below:
browserifyis stuck at 13 for now since we can't mess up support for IE9 and IE10 just yetdependency-checkitself (we bump this once node 4 has reached EOL)mochawant to fix this in a separate PRtap-parserwant to fix this in a separate PRWill squash this.