[AUTH-1236] Prevent conditional requests from being made during tape recording, so that conditional responses are not returned during replay #473
Conversation
…recording, so that conditional responses are not returned during replay.
timdawborn
force-pushed
the
AUTH-1236-prevent-conditional-requests
branch
from
c3cecd9
to
b788613
Compare
timdawborn
force-pushed
the
AUTH-1236-prevent-conditional-requests
branch
from
dd2b63f
to
3f2ad0d
Compare
| delete req.headers["if-modified-since"]; | ||
| delete req.headers["if-none-match"]; |
There was a problem hiding this comment.
Question: do we need to remove the headers from https://nodejs.org/api/http.html#messagerawheaders as well? I assume not if we're only forwarding req.headers elsewhere.
There was a problem hiding this comment.
Good question. I don't believe so as we're copying the headers out of req to pass upstream later on.
src/cli.ts
Outdated
| .option( | ||
| "--prevent-conditional-requests <flag>", | ||
| "When running in record mode, remove `If-*` headers from outgoing requests in an attempt to prevent the suite of conditional responses being returned (304).", | ||
| "true" | ||
| ) |
There was a problem hiding this comment.
nit: perhaps a negated boolean flag is a nicer CLI interface https://github.com/tj/commander.js/#other-option-types-negatable-boolean-and-booleanvalue?
--no-drop-conditional-request-headers ?
There was a problem hiding this comment.
Ah sure, nice idea. I didn't bother looking up the docs for this command line arg parsing library to see if there was an option for that.
| @@ -55,6 +62,12 @@ async function main(argv: string[]) { | |||
| ); | |||
| } | |||
|
|
|||
| if (initialMode === "record" && preventConditionalRequests) { | |||
| console.info( | |||
| "The prevent conditional requests flag is enabled in record mode. All received `If-*` headers will not be forwarded on upstream and will not be recorded in tapes." | |||
There was a problem hiding this comment.
I like @rickyrattlesnake's suggestion of boolean flag, but other than that it looks good to me.
Prevent conditional requests from being made during tape recording, so that conditional responses are not returned during replay.