Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NT] Improve CI setup #505

Merged
merged 8 commits into from
Oct 24, 2023
Merged

[NT] Improve CI setup #505

merged 8 commits into from
Oct 24, 2023

Conversation

timdawborn
Copy link
Contributor

@timdawborn timdawborn commented Oct 23, 2023 •
edited
Loading

Various forms of CI improvements:

  • Switch CircleCI setup to use executors and commands instead of ad-hoc YAML blocks.
  • Generate Junit XML output of the unit tests and upload the test results to CircleCI.
  • Run the tests across multiple versions of NodeJS.
    • I could not get the tests to pass on Node 20 currently, so I've excluded Node 20 for the moment.

@timdawborn timdawborn requested a review from njday October 23, 2023 23:59
@timdawborn timdawborn marked this pull request as ready for review October 23, 2023 23:59
njday
njday approved these changes Oct 24, 2023
View reviewed changes
Copy link

@njday njday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice uplift

@timdawborn timdawborn merged commit 3534d11 into master Oct 24, 2023
8 checks passed
@timdawborn timdawborn deleted the no-ticket-ci-multiple-versions-of-node branch October 24, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njday njday njday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timdawborn @njday