Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT] Use CircleCI matrix for running the same tests across different parameters #571

Merged
merged 5 commits into from
Jan 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 12 additions & 24 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,12 @@ commands:


jobs:
test-node14:
executor: node14
steps:
- run-tests

test-node16:
executor: node16
steps:
- run-tests

test-node18:
executor: node18
run-tests:
parameters:
node-version:
type: string
description: The major version of NodeJS to use.
executor: node<< parameters.node-version >>
steps:
- run-tests

Expand Down Expand Up @@ -111,15 +105,11 @@ jobs:
workflows:
build-and-test:
jobs:
- test-node14:
filters:
tags:
only: /^v[0-9]+\.[0-9]+\.[0-9]+$/
- test-node16:
filters:
tags:
only: /^v[0-9]+\.[0-9]+\.[0-9]+$/
- test-node18:
- run-tests:
name: test-node<< matrix.node-version >>
matrix:
parameters:
node-version: ["14", "16", "18"]
filters:
tags:
only: /^v[0-9]+\.[0-9]+\.[0-9]+$/
Expand All @@ -133,9 +123,7 @@ workflows:
only: /^v[0-9]+\.[0-9]+\.[0-9]+$/
- publish:
requires:
- test-node14
- test-node16
- test-node18
- run-tests
- build-and-run
- lint-check
filters:
Expand Down