[NT] Support NodeJS 20 #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdawborn
force-pushed
the
nt-support-node-20
branch
from
deeefb8
to
e2224cd
Compare
timdawborn
commented
Jan 8, 2024
Comment on lines
+52
to
+54
| // Sleep briefly to allow the OS to free up the port so that we can re-bind it again in the | ||
| // next test. | ||
| await new Promise((r) => setTimeout(r, 1000)); |
There was a problem hiding this comment.
This was needed to get the tests to pass on the NodeJS 20 image. Unsure what specifically changed there to need this change, but this fixed all of the issues.
timdawborn
commented
Jan 8, 2024
| @@ -0,0 +1 @@ | |||
| v20.10.0 | |||
There was a problem hiding this comment.
There wasn't previously an .nvmrc file here. Added one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for NodeJS 20.