Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add a dot in query parameters #1370

Merged
merged 2 commits into from Apr 14, 2021

Conversation

Thodin3
Copy link
Contributor

@Thodin3 Thodin3 commented Apr 13, 2021

Description, Motivation and Context

Please see #1368

Like it's possible to add a dot in HTTP GET parameters, it's allowed in OAS.
It's possible to add it in a query parameter with this Pull request.
The extractQueryParamName regex is extended to .

Checklist:

  • I've added/updated tests to cover my changes
  • I've created an issue associated with this PR

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2021

CLA assistant check
All committers have signed the CLA.

Thodin3 added a commit to Thodin3/spot that referenced this pull request Apr 13, 2021
Thodin3 added a commit to Thodin3/spot that referenced this pull request Apr 13, 2021
@Thodin3 Thodin3 force-pushed the feature/dot_in_query_parameters branch from 49efb8e to 359fc9f Compare April 13, 2021 17:47
@Thodin3 Thodin3 force-pushed the feature/dot_in_query_parameters branch from 359fc9f to d0c4d12 Compare April 13, 2021 17:50
Copy link
Contributor

@lfportal lfportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thodin3!

@lfportal lfportal merged commit 74fb06f into airtasker:master Apr 14, 2021
@lfportal lfportal linked an issue Apr 14, 2021 that may be closed by this pull request
Thodin3 added a commit to Thodin3/spot that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to add a dot in query parameters
3 participants