[PSC-1988] Enable spot mock to have a 404 fallback proxy
#2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdawborn
requested review from
njday and
flavray
and removed request for
a team
flavray
approved these changes
Oct 4, 2023
timdawborn
deleted the
PSC-1988-spot-mock-support-undefined-route-proxy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
In order to make the mock server more useful in the case where you have multiple different upstream servers on the same hostname, this PR adds a new optional fallback proxy to
spot mock, which is used instead of instantly 404'ing the received request if the request does not match any of the given contracts. If provided, instead of 404'ing, it will send the request through to the fallback proxy.