Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

update readme #15

Merged
merged 2 commits into from
May 25, 2014
Merged

update readme #15

merged 2 commits into from
May 25, 2014

Conversation

moretti
Copy link
Contributor

@moretti moretti commented May 22, 2014

$locationProvider.hashPrefix should not contain the # symbol.
See http://stackoverflow.com/a/16678065/63011 for more details.

@moretti
Copy link
Contributor Author

moretti commented May 22, 2014

I'm sorry, I sent this pull request before editing the source code.
I think there is a misunderstanding of how the $locationProvider works.

Basically $locationProvider.hashPrefix should only contain the prefix and not the hash symbol.
Check, for example, how AngularUI Route is composing urls:
https://github.com/angular-ui/ui-router/blob/master/src/urlRouter.js#L388

I made some changes to named-routes.coffee and now it's working as expected.
It's no longer necessary to change prefix using $locationProvider.hashPrefix (it will work even if $locationProvider.hashPrefix is empty) and I moved prefix into the $get method because it wasn't reading the configuration from my app config block.

Paolo Moretti and others added 2 commits May 22, 2014 13:43
`$locationProvider.hashPrefix` should not contain the `#` symbol.
See http://stackoverflow.com/a/16678065/63011 for more details.
airtonix added a commit that referenced this pull request May 25, 2014
@airtonix airtonix merged commit 8344d13 into airtonix:master May 25, 2014
@moretti
Copy link
Contributor Author

moretti commented May 26, 2014

Thanks 👍

@airtonix
Copy link
Owner

@moretti oatmeal for the win!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants