Update reload to exit if parseconfig fails

I spotted that reload didn't exit when parseconfig failed and would continue to run with no knocks configured. Updated the code to still close the logfile and exit if parseconfig fails.
airwoflgh · Nov 27, 2015 · 64230a1 · 64230a1 · airwoflgh · Nov 27, 2015
1 parent e566d49
commit 64230a1
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/knockd.c b/src/knockd.c
@@ -386,15 +386,21 @@ void reload(int signum)
 	}
 	list_free(doors);
 
-	parseconfig(o_cfg);
-
-	vprint("Closing and re-opening log file: %s\n", o_logfile);
-	logprint("Closing and re-opening log file: %s\n", o_logfile);
+	vprint("Closing log file: %s\n", o_logfile);
+	logprint("Closing log file: %s\n", o_logfile);
 
 	/* close and re-open the log file */
 	if(logfd) {
 		fclose(logfd);
 	}
+
+	if(parseconfig(o_cfg)) {
+		exit(1);
+	}
+
+	vprint("Re-opening log file: %s\n", o_logfile);
+	logprint("Re-opening log file: %s\n", o_logfile);
+
 	logfd = fopen(o_logfile, "a");
 	if(logfd == NULL) {
 		perror("warning: cannot open logfile");