[#2275] Allow for multiple webhooks and event filtering #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismatix
commented
Aug 20, 2021
| pathType: Prefix | ||
| backend: | ||
| service: | ||
| name: api-communication | ||
| port: | ||
| number: 80 | ||
| - path: /conversations.info |
There was a problem hiding this comment.
@ljupcovangelski and @pascal-airy I simplified this file a lot by using prefix matching. We don't have to specify every single route if e.g. all /conversations* routes go to api-communication.
chrismatix
commented
Aug 20, 2021
|
|
||
| onEvent = (body: string) => { | ||
| const json = JSON.parse(body) as EventPayload; | ||
| switch (json.type) { | ||
| case 'channel': | ||
| case 'channel.updated': |
There was a problem hiding this comment.
@AudreyKj and @thorstenairy The websocket event names will change a bit in the next release.
chrismatix
requested review from
ljupcovangelski,
pascal-holy,
AitorAlgorta,
AudreyKj and
stayprodio
and removed request for
ljupcovangelski
pascal-holy
reviewed
Aug 20, 2021
backend/webhook/consumer/src/main/java/co/airy/core/webhook/consumer/Consumer.java
Show resolved
Hide resolved
pascal-holy
reviewed
Aug 23, 2021
ljupcovangelski
added a commit
that referenced
this pull request
Aug 23, 2021
ljupcovangelski
approved these changes
Aug 23, 2021
ljupcovangelski
added a commit
that referenced
this pull request
Aug 23, 2021
ljupcovangelski
added a commit
that referenced
this pull request
Aug 24, 2021
ljupcovangelski
added a commit
that referenced
this pull request
Aug 24, 2021
ljupcovangelski
added a commit
that referenced
this pull request
Aug 24, 2021
ljupcovangelski
added a commit
that referenced
this pull request
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2275
TODO:
X-Airy-Content-SignatureheaderUpgrade procedure:
/webhooks.info1.1 Call
/webhooks.infoand note downurlandheaders1.2 At
9.call the/webhooks.subscribewith this dataIf there is no existing webhook, steps 2. - 4. can be skipped. If there is no pre-existing webhook deployment at all, then only the admin app needs to be reset.