Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix to improve robustness #133

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Quick fix to improve robustness #133

merged 3 commits into from
Feb 15, 2022

Conversation

idg10
Copy link
Contributor

@idg10 idg10 commented Feb 15, 2022

This moves the stream reading over to Rx, so we can use the Retry operator to make it more robust.

HowardvanRooijen
HowardvanRooijen approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@HowardvanRooijen HowardvanRooijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@idg10 idg10 merged commit 764d8c8 into master Feb 15, 2022
@idg10 idg10 deleted the feature/try-robustifying branch February 15, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowardvanRooijen HowardvanRooijen HowardvanRooijen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idg10 @HowardvanRooijen