Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letting users define custom global functions that persist, and local functions that are accessible to flow scripts in the same folder #137

Closed
kensoh opened this issue Apr 16, 2018 · 3 comments
Labels

Comments

@kensoh
Copy link
Member

kensoh commented Apr 16, 2018

In current version of TagUI, if custom functions are defined by users, they would be defined as part of the automation flow or subscripts to be called via tagui step. If custom functions are defined in tagui_header.js, they would be overwritten when there is a new release of TagUI.

This issue aims to add support for letting users create a tagui_global.js file in tagui/src folder, which they can define global helper functions for use in their automation scripts. And this tagui_global.js persists with newer TagUI releases as there isn't a tagui_global.js file as part of the repo.

@kensoh kensoh added the feature label Apr 16, 2018
kensoh added a commit that referenced this issue Apr 16, 2018
This commit adds support for letting users create a tagui_custom.js file in tagui/src folder, which they can define global helper functions for use in their automation scripts.

tagui_custom.js will persist with newer TagUI releases as there isn't a tagui_custom.js file as part of the repo.
@kensoh
Copy link
Member Author

kensoh commented Apr 16, 2018

This feature is now usable from the cutting edge version.

@kensoh
Copy link
Member Author

kensoh commented Apr 16, 2018

Rename to tagui_global.js for custom global functions instead of tagui_custom.js, to be more meaningful and representative of its purpose. Later on, can add tagui_global.csv as the global repository file.

kensoh added a commit that referenced this issue Apr 17, 2018
for locally defined functions that are accessible to automation flows in the same folder.

precedence is functions defined in flow script, followed by tagui_local.js (in script folder), followed by tagui_global.js (in tagui/src folder)
@kensoh kensoh changed the title Letting users define custom global functions that persist Letting users define custom global functions that persist, and local functions that are accessible to flow scripts in the same folder Apr 17, 2018
@kensoh
Copy link
Member Author

kensoh commented Apr 17, 2018

Above commit adds support for tagui_local.js for locally defined functions that are accessible to automation flows in the same folder.

Precedence is functions defined in flow script, followed by tagui_local.js (in script folder), followed by tagui_global.js (in tagui/src folder).

This feature is now usable from the cutting edge version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant