Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrome extension css selectors #4

Closed
kensoh opened this issue Feb 8, 2017 · 2 comments
Closed

chrome extension css selectors #4

kensoh opened this issue Feb 8, 2017 · 2 comments
Labels
bug

Comments

@kensoh
Copy link
Member

kensoh commented Feb 8, 2017

ISSUE - sometimes css selectors instead of xpath selectors are returned from extension. FIX - to return all as xpath selectors or cater parser to also handle css selectors
@kensoh kensoh added the bug label Feb 8, 2017
@kensoh kensoh self-assigned this Feb 9, 2017
@kensoh
Copy link
Member Author

kensoh commented Feb 13, 2017

fixed with 44ab4d0 and e628f32

@kensoh kensoh closed this as completed Feb 13, 2017
@kensoh
Copy link
Member Author

kensoh commented Mar 13, 2017

The fixes for #4 are improvements but another better solution is proposed by @danielzzz in #12. It appears to be more robust and balances XPath with CSS well for the TA.Gui dynamic XPath/CSS selector, without overly bias for either one. Have made a few more commits since then to further improve usability of the dynamic selector.

@kensoh kensoh removed their assignment Aug 31, 2017
@andrei152515 andrei152515 mentioned this issue Jul 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kensoh