Sikuli search by variable OCR text - iteration to make it work for variable #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @siowyisheng follow-up patch for #702 for your review and testing. Turns out the previous iteration is not working when a variable is used for the text to be searched using OCR. Hope this would be the final iteration but I think there is likely to be more as this is quite a deviation from the original design and we'll fix new broken cases as they appear. |
|
okay tested with variables and LGTM. |
siowyisheng
pushed a commit
that referenced
this pull request
Mar 10, 2020
…riable (#736) * search by OCR text with variable * search by OCR text with variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up PR to #702