Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.3.0] Abstracting Pytorch example #24

Merged
merged 48 commits into from
Mar 11, 2024
Merged

[0.3.0] Abstracting Pytorch example #24

merged 48 commits into from
Mar 11, 2024

Conversation

Syakyr
Copy link
Collaborator

@Syakyr Syakyr commented Feb 27, 2024

Closes #17.

This is a big merge before freezing the code to 0.3.0 with a number of changes on top of abstracting the Pytorch example and creating a package-agnostic base template to implement models of the user's choosing.

Changes made:

  • Experimental RoCM support
  • Package-agnostic base template to build relevant problem templates from
  • Cosmetic changes for consistency and/or simplicity
  • More explicit methods of deployment depending on use case/availability of infrastructure
  • Refined checks with regards to the cookiecutter input
  • Removed dockerfiles for JupyterLab and VSCode images (moved to kapitan-hull-admin)

deon and others added 30 commits February 22, 2024 14:28
…ce is not part of the problem template list
…o post gen hook to remove unneeded banners
@Syakyr Syakyr added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 27, 2024
@Syakyr Syakyr added this to the 0.3.0 release milestone Feb 27, 2024
@Syakyr Syakyr self-assigned this Feb 27, 2024
@Syakyr Syakyr marked this pull request as draft February 29, 2024 13:43
@Syakyr
Copy link
Collaborator Author

Syakyr commented Mar 10, 2024

Problem with the gpu (model training) Dockerfile such that pytorch is forced to run cpu only due to the dependencies. Would need to find check if nvidia image base is needed by installing the gpu dependencies onto the current cpu image (to reduce image size). Concern is that CUDA components might be installed twice in anaconda namespace, thus increasing the image size for the gpu (model training) image.

@Syakyr
Copy link
Collaborator Author

Syakyr commented Mar 10, 2024

So installing pytorch-cuda as a dependency on ubuntu:20.04 image would allow pytorch to use CUDA, circumventing the need to use the Nvidia images. Checking whether rebuilding the GPU image using the CPU dockerfile as well as modifying the conda yaml file to install gpu-enabled Pytorch packages would result in model training with GPU, or model training with CPU if GPU is not supplied.

@Syakyr Syakyr added ready Ready to be merged and closed and removed bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 11, 2024
@Syakyr Syakyr marked this pull request as ready for review March 11, 2024 04:40
@Syakyr Syakyr merged commit 672ac8b into main Mar 11, 2024
@Syakyr Syakyr deleted the 0.3.0-pytorch-abstract branch March 11, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready to be merged and closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: To remove Pytorch example and separate it as an example section in the documentation
1 participant