Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sentic-GCN to SGNlp #44

Merged
merged 203 commits into from
Jan 18, 2022
Merged

Add Sentic-GCN to SGNlp #44

merged 203 commits into from
Jan 18, 2022

Conversation

raymondng76
Copy link
Collaborator

close #41

This pull request is to add Sentic-GCN models to sgnlp.
Includes the follow components:

  • Models
  • Configs
  • Tokenizers
  • Embedding models
  • Trainer/Evaluator
  • Unit test
  • documentation

Does not include demo_api as it is covered in another issue tickets.

Ng Boon Cheong Raymond and others added 30 commits December 9, 2021 15:48
[#41] initial commit for asgcn
132bbb4
@raymondng76
[#41] add dynamic_rnn module
ae77dc7
@raymondng76
[#41] slight refactor for code reuse
d19add5
@raymondng76
[#41] add gcn class
5292df7
@raymondng76
[#41] add initial data_class
1600754
@raymondng76
[#41] rename asgcn to sentic_asgcn
9b8417b
@raymondng76
[#41] fix wrong import
e290ba4
@raymondng76
[#41] rename SenticGCN to SenticASGCN, add basic config
aeac3bd
@raymondng76
[#41] add SenticASGCNConfig
a2b4701
@raymondng76
[#41] add set random seed helper
0333bab
@raymondng76
[#41] add model init
436240e
@raymondng76
[#41] add draft asgcn model
549e7fc
@raymondng76
[#41] add bucketiterator class
7812f66
@raymondng76
[#41] add preprocess dependency graph class
8487ab3
@raymondng76
[#41] fix typo
25554f5
@raymondng76
[#41] add config for preprocess dependency graph
84dc698
@raymondng76
[#41] add draft tokenizer, add docstring for preprocess dependency gr…
aa3e3d5 
…aphy class
@raymondng76
[#41] fix tokenize method to call right attribute
a519024
@raymondng76
[#41] add converstion helper method to be compliant with huggingface api
bcbb06d
@raymondng76
Merge branch 'dev' into asgcn
9158de3
@raymondng76
[#41] fix tokenization attribute error, add save vocab method
30bfe8e
@raymondng76
[#41] fix tokenize method performing the tokenization twice from PreT…
61c762a 
…rainedTokenizer
@raymondng76
[#41] specify vocab file in tokenizer class, add draft preprocessor
421835e
@raymondng76
[#41] add helper methods to load word vector and generate embedding m…
ffc7d4d 
…atrix
@raymondng76
[#41] flesh out docstrings and typehints for utils method
be7be52
@raymondng76
[#41] add draft ABSADatasetReader class
ed89c1d
@raymondng76
[#41] add raw, graph and tree dataset path to config and dataclass
90d2f6a
@raymondng76
[#41] rework integration for embedding matrix, apply proper formattin…
50ae2f0 
…g with black
@raymondng76
[#41] add missing tokenizer args
21098dd
@raymondng76
[#41] bug fix for missing brackets
8067150
@raymondng76 raymondng76 changed the title Asgcn Add Sentic-GCN to SGNlp Jan 14, 2022
K-WeiMing and others added 21 commits January 14, 2022 13:58
@K-WeiMing
[#43] merge branches
fb63492
@raymondng76
[#41] re-add deleted files during merge
e932971
@raymondng76
[#41] fix broken string and add sentic_gcn to demo_api jsonnet
64d053d
@raymondng76
[#41] added tags to indicate on-prem for CI/CD
475098c
@raymondng76
[#41] remove tags from build stage
905ab95
@raymondng76
[#41] try adding on-prem to jsonnet
dfb49f0
@raymondng76
Revert "[#41] try adding on-prem to jsonnet"
7f0d127 
This reverts commit dfb49f0.
@raymondng76
[#41] try adding tags with proper syntax in jsonnet
c67b048
@raymondng76
[#41] try remove on-prem tag for pre stage
34af1d5
@raymondng76
Revert "[#41] try remove on-prem tag for pre stage"
a842cbc 
This reverts commit 34af1d5.
@raymondng76
[#41] try fix CI/CD pipeline with proper tags
a0b8eaf
@raymondng76
[#41] try fix pipeline adding on-prem tags
578f423
@raymondng76
[#41] remove on-prem tags
2f75e62
@raymondng76
[#41] try adding dind tags for unit tests stage
b2d3f76
@raymondng76
[#41] try adding on-prem tag
8088c22
@raymondng76
[#41] add on-prem tag to prod config
254384a
@raymondng76
[#41] remove list from output
84d58bb
@raymondng76
[#41] update text for model weights and config
038e660
@raymondng76
[#41] standardise aspects key from input batch
d1a366f
@raymondng76
[#41] fix unit tests for aspect changes
d82e779
@raymondng76
[#41] update usage with latest examples
b123236
@jonheng jonheng merged commit c4c5a94 into dev Jan 18, 2022
@jonheng jonheng linked an issue Jan 18, 2022 that may be closed by this pull request
Add Sentic-GCN model to SGNLP #41
Closed
@jonheng jonheng deleted the asgcn branch March 2, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonheng jonheng jonheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sentic-GCN model to SGNLP
3 participants
@raymondng76 @jonheng @K-WeiMing