Skip to content

Commit

Permalink
fix(sign): resolve signing issue caused by re-linking shared lib in *…
Browse files Browse the repository at this point in the history
….eln files

When shared libs are stored in `Contents/Frameworks`, the re-link path
for `/usr/local/lib/gcc/11/libgcc_s.1.dylib` within bundled *.eln files
becomes `@executable_path/../Frameworks/libgcc_s.1.dylib`, which seems to
not leave enough space in the *.eln binary header to add a code
signature with codesign.

This used to work when shared libraries were bundled into
`Contents/MacOS/lib`, leading to a shorter relink path of
`@executable_path/lib/libgcc_s.1.dylib`, which does leave enough space
to add a code signature to *.eln files.
  • Loading branch information
jimeh committed Aug 2, 2021
1 parent 94625fc commit e6b1e5a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build-emacs-for-macos
Expand Up @@ -747,7 +747,7 @@ class AbstractEmbedder
end

def lib_dir
File.join(app, 'Contents', 'Frameworks')
File.join(invocation_dir, 'lib')
end
end

Expand Down

0 comments on commit e6b1e5a

Please sign in to comment.