Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added ability to quit early #126

Merged
merged 10 commits into from
Jun 27, 2024
Merged

feat: added ability to quit early #126

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6ef72c2
feat: added ability to quit early
Henri-ColibrITD May 7, 2024
9c98616
fix: return type compliance
Henri-ColibrITD May 7, 2024
ef6ccf9
chores: reverted undesired autoformat
Henri-ColibrITD May 10, 2024
6c2742b
fix: quitting disabled by default and multiselect taken into account
Henri-ColibrITD Jun 11, 2024
9ac1334
fix: tuple was not subscriptable in old versions of python
Henri-ColibrITD Jun 18, 2024
cbd8b3d
fix: tuple was not subscriptable in old versions of python
Henri-ColibrITD Jun 18, 2024
5d5366e
keys_quit -> quit_keys and type hint more general
Henri-ColibrITD Jun 27, 2024
b7d0832
doc: added example and documented option in readme
Henri-ColibrITD Jun 27, 2024
9d1979e
Merge branch 'aisk:master' into master
Henri-ColibrITD Jun 27, 2024
65f7465
Update README.md
aisk Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/pick/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ class Option:
description: Optional[str] = None


KEY_CTRL_C = 3
KEY_ESCAPE = 27
KEYS_QUIT = (KEY_CTRL_C, KEY_ESCAPE, ord("q"))
KEYS_ENTER = (curses.KEY_ENTER, ord("\n"), ord("\r"))
KEYS_UP = (curses.KEY_UP, ord("k"))
KEYS_DOWN = (curses.KEY_DOWN, ord("j"))
Expand Down Expand Up @@ -182,7 +185,9 @@ def run_loop(
while True:
self.draw(screen)
c = screen.getch()
if c in KEYS_UP:
if c in KEYS_QUIT:
return None, -1
Henri-ColibrITD marked this conversation as resolved.
Show resolved Hide resolved
elif c in KEYS_UP:
self.move_up()
elif c in KEYS_DOWN:
self.move_down()
Expand Down Expand Up @@ -231,7 +236,7 @@ def pick(
min_selection_count: int = 0,
screen: Optional["curses._CursesWindow"] = None,
position: Position = Position(0, 0),
clear_screen = True,
clear_screen: bool = True,
):
picker: Picker = Picker(
options,
Expand Down
Loading