Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support r2d2 as a Connection pool #104

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

letmutx
Copy link
Collaborator

@letmutx letmutx commented Feb 2, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #104 into master will decrease coverage by 1.86%.
The diff coverage is 81.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   50.58%   48.72%   -1.87%     
==========================================
  Files          10       10              
  Lines         682      745      +63     
==========================================
+ Hits          345      363      +18     
- Misses        337      382      +45
Impacted Files Coverage Δ
src/error.rs 5.38% <0%> (-2.86%) ⬇️
src/client.rs 100% <100%> (+4.1%) ⬆️
src/connection.rs 83.59% <85.71%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa9aa8...877f3bb. Read the comment docs.

@letmutx letmutx changed the title WIP: Support r2d2 as a Connection pool Support r2d2 as a Connection pool Feb 5, 2020
@letmutx letmutx requested a review from aisk February 5, 2020 15:18
@letmutx letmutx mentioned this pull request Feb 5, 2020
@letmutx letmutx removed the request for review from aisk February 6, 2020 16:46
@letmutx letmutx merged commit faed4e1 into aisk:master Feb 6, 2020
@letmutx letmutx deleted the connection-pool branch February 6, 2020 16:47
@letmutx
Copy link
Collaborator Author

letmutx commented Feb 6, 2020

I have an additional thing to work on top of this. I am merging this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants