Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious doc test failures #106

Merged
merged 1 commit into from Feb 4, 2020
Merged

Conversation

letmutx
Copy link
Collaborator

@letmutx letmutx commented Feb 3, 2020

Fix #105

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   50.58%   50.58%           
=======================================
  Files          10       10           
  Lines         682      682           
=======================================
  Hits          345      345           
  Misses        337      337
Impacted Files Coverage Δ
src/client.rs 95.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa9aa8...fee659e. Read the comment docs.

@letmutx
Copy link
Collaborator Author

letmutx commented Feb 3, 2020

@aisk CommitCheck doesn't show the expected commit message format. Is it documented somewhere? Please add it to README.md.

@aisk
Copy link
Owner

aisk commented Feb 4, 2020

Sorry I'll add it to README latter. For now, all commit' title must be starting with https://gitmoji.carloscuesta.me/ , and a white space and lower case titles, like:

:bug: fixed something

@letmutx letmutx merged commit dced588 into aisk:master Feb 4, 2020
@letmutx letmutx deleted the fix-spurious-failures branch February 4, 2020 16:31
@aisk aisk mentioned this pull request Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious doc test failures
3 participants