F/#125 create submissions by assignment list #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,7 @@ App.the_modules = { | |||
| 'widget/subject_details': 'modules/subject_details_widget', | |||
| 'widget/assignments': 'modules/assignments_list_widget', | |||
| 'widget/submission_details': 'modules/submission_details_widget', | |||
| 'widget/submissions_list': 'modules/submissions_list_widget', | |||
There was a problem hiding this comment.
You should use the core list widget instead of reinventing the wheel
There was a problem hiding this comment.
I asked a while ago on campfire if I should use a list widget or simply render all submissions with an {{#each}} and I was told to keep it this way for now. Should I change it, though?
There was a problem hiding this comment.
Ok then leave it like this for now. But get reading on the list widget - it's one of the most important in Mozaic core.
|
What's happening with this one? Pls pull master again :) |
| <tr> | ||
| <td><a href ="{{../url}}{{id}}">Submission{{id}}</a></td> | ||
| <td>{{uploaded_at}}</td> | ||
| <td>{{conent}}</td> |
aismail
pushed a commit
that referenced
this pull request
May 17, 2013
…ignment-list F/#125 create submissions by assignment list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.