F/#68 apify contact emails #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bundle.data['contact_emails'] = contact_list | ||
| return bundle | ||
|
|
||
| def determine_format(self, request): |
There was a problem hiding this comment.
Let's not do this. Read about serializers http://django-tastypie.readthedocs.org/en/latest/serialization.html and put it in the base class.
…rmat is now assured by the serializer in BaseResource
|
@bogdans83 , review again, please? :) |
|
lgtm, but you haven't tested out the method :P leave at least a TODO |
|
I'll postpone the merging until I write some tests. Although I'm not fond of it, I have to do it. |
|
|
||
| class BaseResource(ModelResource): | ||
| class Meta: | ||
| pass | ||
| serializer = Serializer(formats=['json']) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API provides a new entry in the Subject resource: contact_emails, which is a list of emails.