Static type for EasyLocalization.assetLoader (#524) #598
+26
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeyinkin
commented
Jun 26, 2023
alexeyinkin
commented
- Resolves Static typing for AssetLoader #524
bw-flagship
reviewed
Jun 26, 2023
| @@ -65,8 +65,7 @@ class EasyLocalization extends StatefulWidget { | |||
| /// Class loader for localization files. | |||
| /// You can use custom loaders from [Easy Localization Loader](https://github.com/aissat/easy_localization_loader) or create your own class. | |||
| /// @Default value `const RootBundleAssetLoader()` | |||
There was a problem hiding this comment.
Is this still correct?
There was a problem hiding this comment.
Yes.
- One can use the loaders from that package, after Delete local AssetLoader class, update dependencies (#46) easy_localization_loader#50 is merged and published.
- One can still create their own class.
- The default is still
const RootBundleAssetLoader().
bw-flagship
approved these changes
Jul 11, 2023
aissat
approved these changes
Sep 1, 2023
|
@alexeyinkin I suppose this is ready to merge after resolving the conflicts, right? |
|
@bw-flagship yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.