239 replace deepsource with open source components #1309
Conversation
|
|
||
| - repo: https://gitlab.com/pycqa/flake8 |
There was a problem hiding this comment.
Please also make sure that mccabe is installed. It can be executed as a flake8-plugin: https://github.com/PyCQA/mccabe
There was a problem hiding this comment.
I add this to the Jenkinsfile as an test which produces output, but it does not fail the pipeline. We did not fix the complexity thing and running the tests through would not be possible any more.
There was a problem hiding this comment.
also checked and added other plugins from flake8.
| @@ -677,7 +671,7 @@ def graceful_shutdown_handler(_signo, _stackFrame): | |||
| aminer_user_id = getpwnam(tmp_username).pw_uid | |||
| if tmp_group is not None: | |||
| aminer_group_id = getgrnam(tmp_group).gr_gid | |||
| except: # skipcq: FLK-E722 | |||
| except KeyError: | |||
There was a problem hiding this comment.
Is this KeyError correct? Do we miss other Exceptions?
There was a problem hiding this comment.
This is the only exception I would expect. The error message (which is unchanged) only explains this error as the user or group name could not be resolved. Other errors will fail the aminer anyways and should either be returned as they are or they should be catched explicitly.
I see nothing that could go wrong with this approach, as the program quits anyways.
add vulture repository to Jenkinsfile and to pre-commit hooks. fix issues from pre-commit hooks (mostly from docformatter)
add pyproject.toml for Vulture add runVulture.sh
fix issue with wrong call to runAminerUntilEnd.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Must haves
Fixes #1305
Submission specific
Describe changes: