-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CanDeactivate and NavigationStart event #143
Comments
The loading bar shouldn't be visible when completed unless there are other pending requests, Thanks! |
@aitboudad Thanks for your help. I have implemented https://stackblitz.com/edit/angular-adzxjm As you can see How to approach that? Consider that we have routes that don't have |
Just published a fix in this.loadingBar.useRef('router').complete(); Please give it a try and let me know if that fixes the issue on your side. |
It seems to work! See: https://stackblitz.com/edit/angular-izoxwf I will wait a new stable release anyway! |
We know,
NavigationStart
is fired beforecanDeactivate
is called.Main problem is that we have no way to disable and enable progress bar programmatically so I have to first call complete method:
just to stop animation waiting user interaction result.
Result: we have progress bar completed but visible.
Any way to disable and enable it completely?
Thanks.
The text was updated successfully, but these errors were encountered: