Graph pruner #1
Open
Graph pruner #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrecki
commented
Dec 3, 2022
Shrecki
commented
- There are still some optis to be done, but base build of octree looks OK
… - Starting implementation of CPP octree with pybind binding
…e leafs and non leaf nodes. - First rough implementation of octree initialization
…for triangle to ray intersect
…atabase more efficiently
…n the triangles are set in an appropriate fashion of total overlap, it is possible to be unable to stop subdivision: consider the case where N triangles perfectly intersect in the center, with N-1 allowed triangles. Then infinite recursion. To save us from this ill-defined behaviour, we should implement an early stopping, namely a max subdivision level.
…o matter what - Missing a happy case test for subdivision, where triangles can actually be properly subdivided
…ore assess if all is working as intended visually!
…af mesh - Tests of intersection based on OBJ files
…, main bottleneck is construction of octree for now - should be implemented in a quicker fashion later down the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.